Re evaluate golanci-lint exclusions (dupl, gofumpt, nestif) #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 15, 2024
lburgazzoli
force-pushed
the
gh-5486-linters-4
branch
from
ac27519
to
7c5162c
Compare
|
✔️ Unit test coverage report - coverage increased from 38.2% to 38.3% (+0.1%) |
lburgazzoli
force-pushed
the
gh-5486-linters-4
branch
from
7c5162c
to
845cfe9
Compare
lburgazzoli
added
the
trigger native test
|
✔️ Unit test coverage report - coverage increased from 38.2% to 38.3% (+0.1%) |
lburgazzoli
force-pushed
the
gh-5486-linters-4
branch
from
845cfe9
to
9057770
Compare
|
✔️ Unit test coverage report - coverage increased from 38.2% to 38.3% (+0.1%) |
squakez
approved these changes
May 16, 2024
lburgazzoli
force-pushed
the
gh-5486-linters-4
branch
from
9057770
to
2d816ba
Compare
|
✔️ Unit test coverage report - coverage increased from 38.6% to 38.7% (+0.1%) |
gansheer
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5486
This PR touches a number source files as consequence of re-enabling the
nestiflinter, which I think is good to have enabled as it allow to follow the happy path is left-aligned go proverb, making the code easier to understand as you should quickly be able to scan down to see the expected execution flow.