Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re evaluate golanci-lint exclusions #5486

Open
10 of 37 tasks
lburgazzoli opened this issue May 9, 2024 · 0 comments
Open
10 of 37 tasks

Re evaluate golanci-lint exclusions #5486

lburgazzoli opened this issue May 9, 2024 · 0 comments
Labels
area/build-operator Related to the internal image build operator area/continuous integration Related to CI and automated testing

Comments

@lburgazzoli
Copy link
Contributor

lburgazzoli commented May 9, 2024 •
edited

Requirement

We should reduce the number of excluded linters to the are minimum.

Problem

Some linters are very useful, like those about complexity or other common best practices but they are disbaled for some reason.

Tasks

We must enable them in https://github.com/apache/camel-k/blob/main/.golangci.yml:

  • cyclop
  • depguard
  • dupl
  • exhaustive
  • exhaustivestruct
  • exhaustruct
  • forbidigo
  • funlen
  • gci
  • gochecknoglobals
  • gochecknoinits
  • gocognit
  • gocyclo
  • godox
  • err113
  • gofumpt
  • gomnd
  • ireturn
  • lll
  • nestif
  • nilnil
  • nlreturn
  • nolintlint
  • paralleltest
  • revive
  • tagalign
  • tagliatelle
  • testpackage
  • varnamelen
  • wastedassign
  • whitespace
  • wrapcheck
  • wsl
  • execinquery
  • mnd
  • perfsprint
  • goconst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-operator Related to the internal image build operator area/continuous integration Related to CI and automated testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lburgazzoli @squakez