[CALCITE-6352] The map_contains_key function may return true when the key and mapkeytype types are different #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key and mapkeytype types are different
mihaibudiu
reviewed
May 3, 2024
| return map.containsKey(key); | ||
| } | ||
|
|
||
| private static boolean isNumericEqual(Object obj1, Object obj2) { | ||
| if (obj1 instanceof Number && obj2 instanceof Number) { | ||
| double num1 = ((Number) obj1).doubleValue(); |
There was a problem hiding this comment.
this may not work for some decimal values which cannot be represented exactly as doubles
in general, it is not recommended to compare floating point values for equality, e.g, https://www.jetbrains.com/help/resharper/CompareOfFloatsByEqualityOperator.html
There was a problem hiding this comment.
@mihaibudiu Should I add a layer of explicit conversion in case to convert the types in map and key to the biggest type
There was a problem hiding this comment.
Or convert BigDecimal for comparison, what do you think
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6352