[CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast semantics Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a piece of #3589 which only contains the fix to CALCITE-6169
This also fixes CALCITE-6366
The main part of the fix is implementing Expressions.convertChecked.
There was a recent implementation of this method, but we replace it in the generated Java code with a call to Primitive.numberValue, which covers more cases than the existing implementation.