Mongo client support #2171
Open
Mongo client support #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TousakaRin
force-pushed
the
helei_mongo_rewrite
branch
3 times, most recently
from
6e1cd9c
to
e5a2355
Compare
added 2 commits
March 21, 2023 14:15
Signed-off-by: helei.sig11 <helei.sig11@bytedance.com>
Signed-off-by: helei.sig11 <helei.sig11@bytedance.com>
TousakaRin
force-pushed
the
helei_mongo_rewrite
branch
from
e5a2355
to
ee12867
Compare
|
Mongo client有专门的支持naming service和load balancer吗？不是用目前brpc已有的支持naming service和load balancer？ |
mongodb 是支持主从和分片的，我觉得可以做成专用的lb和naming service，这块的细节还没怎么看 |
wwbmmm
reviewed
Apr 17, 2023
| @@ -152,6 +152,7 @@ endif() | |||
|
|
|||
| find_package(Protobuf REQUIRED) | |||
| find_package(Threads REQUIRED) | |||
| find_package (bson-1.0 1.7 REQUIRED) | |||
There was a problem hiding this comment.
ok, 整个mongo的client支持都做成一个编译选项吧
| ProcessMongoRequest, NULL, | ||
| SerializeMongoRequest, | ||
| PackMongoRequest, | ||
| ProcessMongoRequest, |
There was a problem hiding this comment.
我觉得可以不支持server端了，mongo协议变动挺大的。要做前后兼容工作量有点大
| LOG(WARNING) << "method count:" << srv_des->method_count() | ||
| << " of MongoService should be equal to 1!"; | ||
| LOG(WARNING) << "method count: " << srv_des->method_count() | ||
| << "of MongoService should be equal to 1!"; |
| } | ||
|
|
||
| bool bson_get_double(bson_t* doc, const char *key, double *value) { | ||
| assert(doc); |
|
不支持auth? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support mongo client
原pr：#1808
官方reference： https://www.mongodb.com/docs/manual/
目前能够demo插入和查询，还需要做的：
Issue Number:
#1807
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
影响mongo protocol的server端的向后兼容。
Mongo protocol 本身已经不再向前兼容
Check List: