AVRO-2773: [C] Add decimal logical schema #2891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is an alternative to #843 where the decimal support is added to the value api instead of the deprecated datum api, and decimals are a "first class citizen" in that |
This adds a new AVRO_DECIMAL avro_type_t and uses the existing getters and setters for value objects: decimal objects are encoded as either bytes or fixed. For the deprecated datum api, decimal schemas decay to their underlying bytes or fixed schema: i.e. the legacy api doesn't support logical schemas. Although this patch adds decimal logical schema support, it does not provide any decimal support at the "api level": decimal objects are still read and written as the underlying bytes and fixed objects they were previously. Signed-off-by: Sahil Kang <sahil.kang@asilaycomputing.com> Signed-off-by: Sahil Kang <sahilkang@google.com>
|
the latest changes link |
This patch adds "api level" support for decimal objects: these functions allow manipulating decimal objects at a higher-level than the underlying bytes and fixed objects. Signed-off-by: Sahil Kang <sahil.kang@asilaycomputing.com> Signed-off-by: Sahil Kang <sahilkang@google.com>
|
I was able to run the CI in my own fork and debugged until the latest changes passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-2773
What is the purpose of the change
These two commits add decimal logical schema support for C: the first commit adds the base layer and the second commit adds higher-level functions to manipulate decimal objects beyond their serialized representation.
Verifying this change
Existing tests were updated and new tests were added to exercise the new functionality.
Documentation
This introduces two new functions which are documented along with the existing functions.
For pre-existing functionality, the underlying bytes and fixed getter/setters can still be used with decimal objects.