Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): the translation of upstream #1295

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 30, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Backend: The code logic of this part is split into many places, and there is redundancy.

  • Decouple the translation of upstream, the logic of this part only exists in one place.
  • Delete redundant codes.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #1295 (23fe9e6) into master (f71b376) will increase coverage by 0.73%.
The diff coverage is 15.67%.

@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   40.62%   41.35%   +0.73%     
==========================================
  Files          75       75              
  Lines        7006     6771     -235     
==========================================
- Hits         2846     2800      -46     
+ Misses       3847     3657     -190     
- Partials      313      314       +1     
Impacted Files Coverage Δ
...kg/providers/apisix/translation/apisix_upstream.go 100.00% <ø> (ø)
.../providers/gateway/translation/gateway_tlsroute.go 0.00% <0.00%> (ø)
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)
pkg/providers/translation/translator.go 0.00% <ø> (ø)
pkg/providers/translation/upstream.go 12.42% <14.70%> (ø)
pkg/providers/apisix/translation/apisix_route.go 19.35% <20.83%> (+0.21%) ⬆️
pkg/providers/translation/apisix_upstream.go 80.84% <57.14%> (-0.05%) ⬇️
pkg/providers/apisix/translation/apisix_plugin.go 57.18% <100.00%> (-0.36%) ⬇️
...providers/gateway/translation/gateway_httproute.go 64.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan changed the title refactor: transalte of upstream chore(refactor): transalte of upstream Aug 31, 2022
@AlinsRan AlinsRan marked this pull request as ready for review August 31, 2022 02:51
@AlinsRan AlinsRan changed the title chore(refactor): transalte of upstream chore(refactor): the translation of upstream Aug 31, 2022
pkg/providers/translation/translator.go Outdated Show resolved Hide resolved
pkg/providers/translation/translator.go Outdated Show resolved Hide resolved
pkg/providers/translation/upstream.go Outdated Show resolved Hide resolved
pkg/providers/translation/upstream.go Outdated Show resolved Hide resolved
pkg/providers/translation/upstream.go Outdated Show resolved Hide resolved
pkg/providers/translation/translator.go Outdated Show resolved Hide resolved
pkg/providers/translation/translator.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

could you please resolve conflicts? thanks

@tao12345666333
Copy link
Member

Sorry for delay.
There are too many conflicts now. If you want to proceed, you need to resolve the conflict first. thanks

@tao12345666333
Copy link
Member

Since there are tons of conflicts and no updates yet, I want to put it in v1.7. thanks

@tao12345666333 tao12345666333 modified the milestones: v1.6.0, v1.7.0 Dec 12, 2022
@tao12345666333 tao12345666333 modified the milestones: v1.7.0, 1.8.0 Sep 1, 2023
@AlinsRan AlinsRan marked this pull request as draft September 1, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants