fix: fail when use standalone mode (#541) #547
Conversation
|
Thanks for the PR. Debian standalone CI is failing. Please take a look. |
|
Hi there, still failing |
|
Think I fixed it now. I had broken some |
|
Hi @fvilla-netnix unfortunately tests are still falling. For future reference, it is easier to open PRs to the main branch of your fork to test CIs. This requires no approvals from maintainers and you could get immediate feedback. Since this PR is already opened, I'm not sure if you could still open one to your main branch; likely not. |
| if [ "$APISIX_STAND_ALONE" = "true" ]; then | ||
| # If the file is not present then initialise the content otherwise check relevant keys for standalone mode | ||
| if [ ! -f "${PREFIX}/conf/config.yaml" ]; then | ||
| cat > ${PREFIX}/conf/config.yaml << _EOC_ |
There was a problem hiding this comment.
Why do you change these indents? please leave it as it is, just fix the bug is enough
There was a problem hiding this comment.
Should I undo those changes? The indentation was driving me crazy in my IDE since it was split between 2 spaces and 4.
There was a problem hiding this comment.
Yes, please undo those changes, the pr should be as small as possible
monkeyDluffy6017
changed the title
| /usr/bin/apisix init | ||
| /usr/bin/apisix init_etcd | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Please change the irrelevant indentation changes back for easier review. Thanks.
This aims to fix an existing issue that causes containerized deployments to fail when a config file is provided by the user while in standalone mode.
This is because when in standalone mode the
docker-entrypoint.shscript tries to create theconfig.yamlfile or update it's keys to ensure it is setup correctly.My fix allow users to use read-only files by removing write operations from the script and replaces them with checks and warnings to stop users from using invalid config files.