Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2226]: Rename Flink Model Arctic to Amoro #2812

Closed
wants to merge 1 commit into from

Conversation

czy006
Copy link
Contributor

@czy006 czy006 commented May 6, 2024

Why are the changes needed?

Close #2226 .

Brief change log

  • rename flink mode java file name prefix to amoro

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label May 6, 2024
@czy006 czy006 added the type:subtask Subtask of another issue label May 6, 2024
@xleoken
Copy link
Member

xleoken commented May 8, 2024

👍

@xieyi888
Copy link
Contributor

xieyi888 commented May 8, 2024

It seems variable, method, comments which contains arctic also need to be renamed to amoro in new PR in the future?

@czy006
Copy link
Contributor Author

czy006 commented May 11, 2024

Yes . this pr just renames some classes, if we need to change some of the configuration from arctic to amoro, do we have to break some compatibility? Maybe it can also be done in this pr @xieyi888

@zhoujinsong
Copy link
Contributor

Thanks for the contribution!

But I don't think renaming arctic to amoro in all places is a good solution here.
The new project name amoro means a lot more than just the mixed-format now.
So I tried to resolve this issue by #2848 , can you help to review it? @czy006 @xieyi888

@zhoujinsong
Copy link
Contributor

Completed by #2848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format type:subtask Subtask of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Rename Flink Model Arctic to Amoro
4 participants