WIP: AIP-58: Add ObjectStoragePath dag loader #39647
Open
+478
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolkedebruin
requested review from
jedcunningham,
ephraimbuddy,
kaxil,
XD-DENG and
ashb
as code owners
bolkedebruin
commented
May 26, 2024
| @@ -128,10 +129,9 @@ def test_find_path_from_directory_glob_ignore(self): | |||
| ] | |||
| should_not_ignore = [ | |||
| "test_on_kill.py", | |||
| "test_dont_ignore_this.py", | |||
| # "test_dont_ignore_this.py", | |||
There was a problem hiding this comment.
I cannot figure out why this is in the 'should ignore' list. The glob pattern actually excludes this. So if someone can shed some light on this that would be appreciated.
uranusjr
reviewed
May 28, 2024
| @@ -205,7 +207,7 @@ def start(self) -> None: | |||
| with zipfile.ZipFile(self.file_path) as z: | |||
| zip_file_paths.extend( | |||
| [ | |||
| os.path.join(self.file_path, info.filename) | |||
| Path(os.path.join(self.file_path, info.filename)) | |||
There was a problem hiding this comment.
Suggested change
| Path(os.path.join(self.file_path, info.filename)) | |
| Path(self.file_path, info.filename) |
uranusjr
reviewed
May 28, 2024
| @@ -426,6 +428,8 @@ def manage_slas(cls, dag_folder, dag_id: str, session: Session = NEW_SESSION) -> | |||
|
|
|||
| We are assuming that the scheduler runs often, so we only check for | |||
| tasks that should have succeeded in the past hour. | |||
|
|
|||
| fixme: remove this from the dag processor | |||
There was a problem hiding this comment.
This shouldn’t be a part of the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.