Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FTPHook to change port number #39465

Merged
merged 9 commits into from
May 27, 2024
Merged

Conversation

VelmiraPetkova
Copy link
Contributor

Allow FTPHook to use a custom FTP port number

closes: #39308

Copy link

boring-cyborg bot commented May 7, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR.
Can you add the test case for custom port?

@VelmiraPetkova
Copy link
Contributor Author

Yes, I'll do the test case over the weekend.

@VelmiraPetkova
Copy link
Contributor Author

I did some tests and fixed a tiny bug, when no port is supplied.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VelmiraPetkova
LGTM +1

@eladkal
Copy link
Contributor

eladkal commented May 26, 2024

@VelmiraPetkova can you please fix static checks?

@VelmiraPetkova
Copy link
Contributor Author

Sorry for the delay. I updated the PR. Could you please take a look? Thank you!

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @VelmiraPetkova!

@dirrao wdyt?

@potiuk
Copy link
Member

potiuk commented May 27, 2024

The failing integration test case is a flake - mssql does not have enough time to start. This has been fixed in #39866

@potiuk potiuk merged commit 9f0b025 into apache:main May 27, 2024
40 of 41 checks passed
Copy link

boring-cyborg bot commented May 27, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTPHook doesn't not allow to change port
6 participants