-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable mysql keda support for triggerer #37365
Open
claneys
wants to merge
4
commits into
apache:main
Choose a base branch
from
claneys:feat/enable-mysql-keda-support-triggerer
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: enable mysql keda support for triggerer #37365
claneys
wants to merge
4
commits into
apache:main
from
claneys:feat/enable-mysql-keda-support-triggerer
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claneys
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
February 12, 2024 16:53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs a test as you did in the other PR
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
February 12, 2024 19:18
86d32d9
to
244fe48
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
7 times, most recently
from
February 19, 2024 15:00
a6aab9a
to
f0636e4
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
February 23, 2024 17:04
a0492f6
to
d804968
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
February 28, 2024 09:13
d804968
to
e54cdaf
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
March 7, 2024 10:50
b651318
to
b0e5375
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
3 times, most recently
from
March 15, 2024 13:19
cb956bb
to
e502d3c
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
7 times, most recently
from
April 15, 2024 19:12
51dd63c
to
5699e05
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
April 22, 2024 12:12
59093b4
to
5632a5d
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
6 times, most recently
from
April 30, 2024 12:06
01b0a81
to
d58108c
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
May 1, 2024 21:15
d58108c
to
4535f86
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
May 13, 2024 08:22
4535f86
to
d816009
Compare
Hi, Is there anything blocking this PR to be merge ? I might miss something. Thanks 🙏 cc: @jedcunningham |
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
2 times, most recently
from
May 20, 2024 21:15
6d2e6dd
to
cd3519e
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
2 times, most recently
from
May 22, 2024 20:50
da208a8
to
df85d20
Compare
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Also fix typo with worker tests targeting triggerer resources. Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
May 29, 2024 12:33
df85d20
to
d5b358e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the previous PR #36167 about MySQL Keda trigger support on workers and is the adaptation to the triggerer statefulset.