Update .gitignore #1814
Open
Update .gitignore #1814
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a slash (/) after .idea and .deps to indicate that they are directories.
rafsun42
reviewed
May 10, 2024
| *.o | ||
| *.so | ||
| .gitignore |
There was a problem hiding this comment.
I don't think we should put .gitignore there.
There was a problem hiding this comment.
I know it seems like redundant but I added .gitignore to maintain consistency and prevent accidental commits of this file, ensuring clarity in our version control process. And actually it also serves as a reminder for all contributors that we should ignore this file itself to prevent accidental commits.
There was a problem hiding this comment.
@rafsun42 +1
Other changes too.
There was a problem hiding this comment.
I don't know what's wrong with my changes, it gives clarity and better understanding of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a slash (/) after .idea and .deps to indicate that they are directories.