simplify nested condition #1206
Conversation
src/backend/catalog/ag_catalog.c
Outdated
| @@ -178,24 +177,19 @@ static void object_access(ObjectAccessType access, Oid class_id, Oid object_id, | |||
| * The above applies to DROP TABLE command too. | |||
| */ | |||
|
|
|||
| if (drop_arg->dropflags & PERFORM_DELETION_INTERNAL) | |||
There was a problem hiding this comment.
Does this change break for the case class_id == RelationRelationId?
There was a problem hiding this comment.
@cmucheru
Could you elaborate more? In this case, the function calls delete_label first before returning. But with your change, it returns without calling that function. Does it have side effect?
There was a problem hiding this comment.
@rafsun42 PERFOM_DELETION_INTERNAL is evaluated separately before checking the namespaces and relations. If it is set, the delete_label is not called.
|
Why are the files in |
|
Why so many modified files? |
|
@cmucheru The tests are failing at |
|
@rafsun42 thankyou. I am unfamiliar with the tests. I will like to check my code again to pass the tests in catalog.sql . |
|
This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for further 7 days with no activity |
Simplify nested function for readability