Implemented get_fast_buffer_spectrum() for the cseabreeze backend #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ed now and tested again with spectrometer.
for more information, see https://pre-commit.ci
|
Thank you so much ❤️ I'll try to get out a release very soon! |
|
You can check out the change set here: 39278ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the get_fast_buffer_spectrum() method for the cseabreeze backend.
For the data retrievel the length of a raw spectrum must be known so I also added the _raw_spectrum_length() property.
The buffered data is returned as a list of namedtuples including the metadata and intensity information.
I could not find the right place for the documentation in the github repository, so I did not add any documentation appart from the basic code commenting.