change expand archive to use powershell method #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuriq
reviewed
Jun 17, 2020
| foreach($item in $zip.items()) { | ||
| $shell.Namespace('#{destination}').copyhere($item) | ||
| } | ||
| Expand-Archive '#{package_file}' '#{destination}' |
There was a problem hiding this comment.
This cmdlet is available from Powershell 5.1 only. Older version won't be supported. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using powershell script that utilizes shell, use "Expand-Archive" powershell functionality to unzip zip files.
The fix is for nano / headless windows servers, where shell is not available.