extract widget macro parsing from expansion #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
force-pushed
the
extract-parsing
branch
2 times, most recently
from
77732f0
to
92daed1
Compare
antoyo
reviewed
Jul 6, 2021
| self.properties_model_map = Some(view.properties_model_map); | ||
| new_items.push(view.item); | ||
| self.widgets.insert(self.root_widget.clone().expect("root widget"), | ||
| self.root_widget_type.clone().expect("root widget type")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit separates the parsing step from the expansion step in the
widgetmacro. It makes it clearer which items are required vs optional, and improves the error messages.