Prefer attribute style selector when an id starts with a digit #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
requested changes
Apr 28, 2023
| @@ -356,6 +357,7 @@ function cssesc(string: string, opt: Partial<typeof defaultOptions> = {}) { | |||
| } | |||
| const quote = options.quotes == 'double' ? '"' : '\'' | |||
| const isIdentifier = options.isIdentifier | |||
| const isId = options.isId | |||
There was a problem hiding this comment.
isId and isIdentifier seems to be very same. Let's rename on or another.
| @@ -188,7 +188,7 @@ function id(input: Element): Knot | null { | |||
| const elementId = input.getAttribute('id') | |||
| if (elementId && config.idName(elementId)) { | |||
| return { | |||
| name: '#' + cssesc(elementId, {isIdentifier: true}), | |||
| name: cssesc(elementId, {isIdentifier: true, isId: true}), | |||
There was a problem hiding this comment.
Also let's add some test for this case.
|
Any movement on this? Still a big problem almost a year later |
|
Any volunteers to refactor this pr? |
|
I really don't know what was meant by I don't see the problem with having them both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick attempt at #67
Apologies I haven't been able to run test cases on my local machine so this might be all worthless.
(can't run tests due to microsoft/TypeScript#51567 )