Webhook Authentication For WebRTC Play

[lastpeony]

#6211

With this form this PR breaks backward compatability of webhook publish authentication because there is a new app setting webhookPublishAuthEnabled and webhookPlayAuthEnabled
previously webhook auth was only for publish and webhook publish was enabled if webhook auth url is not empty.

[mekya]

hi @lastpeony ,

Thank you for the implementation.

I read your comment and had a review of the PR. I'd like to discuss if there is an alternative way to make this implementation without breaking backward compatibility. Because the cost of breaking backward compatibility includes extra support and unhappy users, which may mean churn.

Then my question is: What's the alternative implementation to not break backward compatibility?

[mekya]

Commented on the PR directly to find out the way without breaking backward compatibility

[lastpeony]

Hi @mekya Thank you for the review.
We can eliminate webhookPublishAuthEnabled and webhookPlayAuthEnabled, and instead utilize webhookAuthUrl exclusively for publishing purposes while introducing a new setting for webhookPlayAuthUrl. This adjustment might appear confusing in the app settings, but with your approval, I can implement it to maintain backward compatibility.

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[mekya]

Thank you @lastpeony