Add admin, presenter, publisher request and publisher from listener lists into broadcast object #6148
Conversation
mustafaboleken
changed the title
There was a problem hiding this comment.
Thank you @mustafaboleken for the implementation.
I see some opportunities to make it more simple. Here are my ideas, we can discuss it later
- No need to have new abstract methods in DataStore. updateBroadcast method is enough
- No need to have
presenterListfield in broadcast object. They are subtracks of the main stream and there is a field for subtracks. - No need to have publisherFromListener because they are again subtracks.
- Rename publisherRequestList to
subtrackRequestListor something similar
| @@ -207,6 +207,18 @@ public class Broadcast { | |||
| @ApiModelProperty(value = "Initial time to start playing. It can be used in VoD file or stream sources that has seek support") | |||
| private long seekTimeInMs = 0; | |||
|
|
|||
| @ApiModelProperty(value = "The list of the play only users who requested to publish the stream. It is used in conference scenario.") | |||
| List<String> publisherRequestList = new ArrayList<String>(); | |||
There was a problem hiding this comment.
These are the subsriberId of the user or they are stream id?
| List<String> publisherRequestList = new ArrayList<String>(); | ||
|
|
||
| @ApiModelProperty(value = "The list of the users who are approved to publish the stream. It is used in conference scenario.") | ||
| List<String> publisherFromListenerList = new ArrayList<String>(); |
There was a problem hiding this comment.
Do we need to have different fields for user scenarios? I mean publisherFromListenerList seems like scenario specific to me.
| List<String> presenterList = new ArrayList<String>(); | ||
|
|
||
| @ApiModelProperty(value = "The list of the admin users. It is used in conference scenario.") | ||
| List<String> adminList = new ArrayList<String>(); |
There was a problem hiding this comment.
These are the subscriberIds?
| List<String> publisherFromListenerList = new ArrayList<String>(); | ||
|
|
||
| @ApiModelProperty(value = "The list of the presenter users. It is used in conference scenario.") | ||
| List<String> presenterList = new ArrayList<String>(); |
There was a problem hiding this comment.
presenterList is also the subtracks of this stream. Do we need to have additional field?
| * @param streamId - stream id | ||
| * @return boolean - success | ||
| */ | ||
| public abstract boolean addIntoPublisherRequestList(String mainTrackId, String streamId); |
There was a problem hiding this comment.
I think we don't need to additional methods for the new fields, we can just use the updateBroadcast method
|
@mekya thank you for your review. I understand your points but for some scenarios, it's hard to keep track of subtracts. I will ask them in a meeting. |
|
|
#6147