Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast Level ABR Settings #6145

Merged
merged 29 commits into from May 24, 2024
Merged

Broadcast Level ABR Settings #6145

merged 29 commits into from May 24, 2024

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony commented Feb 29, 2024 •
edited by mekya

@lastpeony lastpeony mentioned this pull request Mar 3, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mekya
mekya requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lastpeony ,
Thank you for the implementation.

I've some comments and I'll make the refactor to proceed faster to merge. Please watch the commits and let me know if you want to discuss

Cheers

src/main/java/io/antmedia/datastore/db/types/Broadcast.java Outdated Show resolved Hide resolved
src/main/java/org/red5/server/stream/ClientBroadcastStream.java Outdated Show resolved Hide resolved
src/test/java/io/antmedia/test/db/DBStoresUnitTest.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mekya
Copy link
Contributor

mekya commented May 24, 2024

This pull request enables users to configure ABR at the broadcast level. When ABR is specified at the broadcast level, it takes precedence over the app settings ABR.

To set ABR to a broadcast update broadcast object encoderSettingsString with JSON string or create broadcast with it.

https://gitlab.com/Ant-Media/Ant-Media-Enterprise/-/merge_requests/667

#6144

@mekya mekya merged commit 88adc23 into master May 24, 2024
3 checks passed
@mekya mekya deleted the broadcastAbr branch May 24, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lastpeony @mekya @burak-58