Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max participant capacity to conferences(aka. subtracks) #5727

Merged
merged 7 commits into from May 16, 2024
Merged

Add max participant capacity to conferences(aka. subtracks) #5727

merged 7 commits into from May 16, 2024

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony commented Oct 24, 2023 •
edited by mekya

@lastpeony lastpeony force-pushed the conferenceRoomParticipantCapacity branch from 8597d17 to 42b273c Compare October 24, 2023 22:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@lastpeony lastpeony requested a review from mekya October 28, 2023 13:29
@mekya
Copy link
Contributor

mekya commented May 16, 2024

Hi @lastpeony,
Thank you for the implementation.

As our approach is to refactor the conferencing and remove the ConferenceRoom because it creates extra ambiguity.
We've made this refactor #6325 and I'm changing this implementation to not use ConferenceRoom for this feature.

FYI

Cheers
Oguz

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
64 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mekya mekya changed the title add max participant capacity feature to conference room Add max participant capacity to conferences(aka. subtracks) May 16, 2024
@mekya mekya merged commit 9c268c0 into master May 16, 2024
3 checks passed
@mekya mekya deleted the conferenceRoomParticipantCapacity branch May 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lastpeony @mekya