New webhooks playStart, playStop, recordStart issue #4666 #4738

lastpeony · 2023-01-08T20:38:17Z

#4666

Documentation PR is waiting for this to be merged

src/main/java/io/antmedia/AntMediaApplicationAdapter.java

…Server into newWebHooks

src/main/java/io/antmedia/AntMediaApplicationAdapter.java

sonatype-lift · 2023-01-16T12:51:05Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ant-media/Ant-Media-Server/4738.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/ant-media/Ant-Media-Server/4738.diff | git apply

Once you're satisfied commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

sonatype-lift · 2023-01-17T09:22:32Z

src/main/java/io/antmedia/statistic/HlsViewerStats.java

@@ -28,11 +29,12 @@ public void setApplicationContext(ApplicationContext applicationContext)  {

 		AppSettings settings = (AppSettings)applicationContext.getBean(AppSettings.BEAN_NAME);
 		timeoutMS = getTimeoutMSFromSettings(settings, timeoutMS, HLS_TYPE);
-
+		final AntMediaApplicationAdapter antMediaApplicationAdapter = (AntMediaApplicationAdapter)applicationContext.getBean(AntMediaApplicationAdapter.BEAN_NAME);
+
 		vertx.setPeriodic(DEFAULT_TIME_PERIOD_FOR_VIEWER_COUNT, yt-> 
 		{
 			synchronized (lock) {


SynchronizeOnNonFinalField: Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T09:22:34Z

src/main/java/io/antmedia/statistic/ViewerStats.java

 	{
 		//do not block the thread, run in vertx event queue 
 		vertx.runOnContext(h -> {
-
 			synchronized (lock) {


SynchronizeOnNonFinalField: Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T09:22:35Z

src/main/java/io/antmedia/statistic/IStreamStats.java

@@ -1,13 +1,15 @@
 package io.antmedia.statistic;

+import io.antmedia.AntMediaApplicationAdapter;
+
 public interface IStreamStats {

 	/**
 	 * Register a new viewer to a stream
 	 * @param streamId


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param streamId

*

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T09:22:37Z

src/main/java/io/antmedia/statistic/IStreamStats.java

@@ -1,13 +1,15 @@
 package io.antmedia.statistic;

+import io.antmedia.AntMediaApplicationAdapter;
+
 public interface IStreamStats {

 	/**
 	 * Register a new viewer to a stream
 	 * @param streamId
 	 * @param sessionId


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param sessionId

*

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T09:22:39Z

src/main/java/io/antmedia/AntMediaApplicationAdapter.java

@@ -539,13 +538,60 @@ public void resetDASHStats(String streamId) {
 		}
 	}

+	public void sendStartPlayWebHook(final String streamId, final String viewerId){
+		final Broadcast broadcast = getDataStore().get(streamId);


THREAD_SAFETY_VIOLATION: Unprotected write. Non-private method AntMediaApplicationAdapter.sendStartPlayWebHook(...) indirectly writes to field this.dataStore outside of synchronization.
Reporting because another access to the same memory occurs on a background thread, although this access may not.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T09:22:41Z

src/main/java/io/antmedia/AntMediaApplicationAdapter.java

 	@Override
 	public void streamPlayItemPlay(ISubscriberStream stream, IPlayItem item, boolean isLive) {
-		vertx.setTimer(1, l -> getDataStore().updateRtmpViewerCount(item.getName(), true));
+		final String streamId = item.getName();
+		sendStartPlayWebHook(streamId, getRtmpViewerId());


THREAD_SAFETY_VIOLATION: Unprotected write. Non-private method AntMediaApplicationAdapter.streamPlayItemPlay(...) indirectly writes to field this.dataStore outside of synchronization.
Reporting because another access to the same memory occurs on a background thread, although this access may not.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

…Server into newWebHooks

src/main/java/io/antmedia/statistic/DashViewerStats.java

sonatype-lift · 2023-01-17T19:31:01Z

src/main/java/io/antmedia/muxer/MuxAdaptor.java

@@ -1681,7 +1681,6 @@ private Muxer addMp4Muxer() {
 	 * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

lastpeony · 2023-03-03T15:15:54Z

SonarCloud Quality Gate failed.

0 Bugs 0 Vulnerabilities 1 Security Hotspot 5 Code Smells

81.2% Coverage 8.4% Duplication

there is no meaningful code duplication(please review just in case)
security hotspot warning also has no negative affect.

mekya

I try to make a quick review and request some changes. Please take a look at the comments. Please make the quality gate pass on sonarcloud and sonatype-lift

src/main/java/io/antmedia/AntMediaApplicationAdapter.java

sonarcloud · 2023-03-10T15:08:30Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
1 Security Hotspot
6 Code Smells

83.5% Coverage
0.0% Duplication

sonarcloud · 2023-06-20T19:16:39Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

82.5% Coverage
0.0% Duplication

sonarcloud · 2023-10-21T21:52:04Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
1 Security Hotspot
5 Code Smells

85.6% Coverage
0.0% Duplication

The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

New webhooks playStart, playStop, recordStart issue #4666

a029073

sonatype-lift bot reviewed Jan 8, 2023

View reviewed changes

src/main/java/io/antmedia/AntMediaApplicationAdapter.java Show resolved Hide resolved

lastpeony added 4 commits January 9, 2023 01:06

New webhooks playStart, playStop, recordStart issue #4666

88444c5

Merge branch 'newWebHooks' of https://github.com/ant-media/Ant-Media-…

364d9bd

…Server into newWebHooks

New webhooks playStart, playStop, recordStart issue #4666

f4ec03a

New webhooks playStart, playStop, recordStart issue #4666

671f9fa

mustafaboleken linked an issue Jan 9, 2023 that may be closed by this pull request

Support playStart, playStop, recordStart webhooks with the viewer info if available #4666

Open

new web hooks

a59ec87

sonatype-lift bot reviewed Jan 16, 2023

View reviewed changes