fix(form): 修复openChange打开时不触发问题 #8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Deploying PR Preview... |
|
一般一个modaforml默认都是不打开的，当他的open=true时，其实就隐含了一次change |
|
这样有可能触发两次呢，你是什么场景？ |
外部控制open情况，我也遇到了，改了一个遍 |
通过props控制open的场景。另外，触发两次我觉得是符合逻辑的，打开一次，关闭一次，因为一般来说modalform默认都是不打开的，或者再加一个属性，控制打开的时候是否执行onOpenChange. |
|
大佬们，抓紧时间合一下，炸了不能用，只能倒退版本了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果ModalForm的open状态由父级通过props控制，并且需要在打开时对form设定初值，就需要监听propOpen的状态，并在其为 true时执行一次onOpenChange。