New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(color): @ctrl/tinycolor to color2k #48671
Draft
guoyunhe
wants to merge
4
commits into
ant-design:master
Choose a base branch
from
guoyunhe:tinycolor4
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
还有上游包使用的 @ctrl/tinycolor 。 |
不能单纯直接改,而且不能master修改。 |
感觉不错,但是 color2k 的文档说只能将颜色输出 rgba 和 hsla 🤔,并且 antd 暴露出去的方法支持更多的 format 。会不会 break change 呢 两者下载趋势:https://npmtrends.com/@ctrl/tinycolor-vs-color2k 对我来说可以试试能不能把我的 dumi-plugin-color-chunk 重构一下。 |
|
好多冲突 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
@ctrl/tinycolor 的大小为 6.4KB,而 color2k 为 2.9KB,理论上可以让总体积减少 3.5KB
📝 Changelog
☑️ Self-Check before Merge