Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mentions support deleting an entire item with a single delete key press #48035

Closed
wants to merge 118 commits into from

Conversation

CooperHash
Copy link
Contributor

…ey press

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#47968

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add a new props to delete item in Mention
🇨🇳 Chinese 新增Mention组件的props

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Prepare preview

Copy link
Contributor

github-actions bot commented Mar 22, 2024

👁 Visual-Regression Diff Building... ⏳

This PR is under visual-regression-diff building, please wait for the result.

@CooperHash
Copy link
Contributor Author

CooperHash commented Mar 22, 2024

新增feat的props的命名不规范,待反馈

Copy link

codesandbox-ci bot commented Mar 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CooperHash
Copy link
Contributor Author

CooperHash commented Mar 25, 2024

新增feat的props的命名不规范,待反馈

@MadCcc @afc163 pls take a look

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (311a718) to head (13babb9).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48035   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        12699     12707    +8     
  Branches      3339      3343    +4     
=========================================
+ Hits         12699     12707    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 10, 2024

请Rebase和解决CI报错

li-jia-nan and others added 17 commits April 10, 2024 17:23
* fix: adjust the order of style prop

* test: update snap

* test: add test case
* fix: 修复 menu openKeys 计算问题

* feat: keys

* feat: 优化代码,避免 eslint

* feat: 优化代码,避免 eslint

* feat: 3级增加为3条数据,为了换行,便于代码查看

* feat: 删除受控 selectedKeys

* feat: 优化代码

* feat: snap

* feat: 优化代码去掉lint

* feat: 代码优化

* feat: 删除 as 因为 onOpenChange 不是 React.Key 了

* feat: 优化代码

* feat: 添加删移除所有子集逻辑
* demo: App demo update

* test: Update test snapshots
* docs: add 5.15.4 chaneglog

* fix typo

* Update CHANGELOG.zh-CN.md

Co-authored-by: lijianan <574980606@qq.com>
Signed-off-by: 陈帅 <qixian.cs@outlook.com>

* Update CHANGELOG.en-US.md

Co-authored-by: lijianan <574980606@qq.com>
Signed-off-by: 陈帅 <qixian.cs@outlook.com>

* fix

* fix

* fix lint

* Update CHANGELOG.en-US.md

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: 陈帅 <qixian.cs@outlook.com>

* fix

* fix

---------

Signed-off-by: 陈帅 <qixian.cs@outlook.com>
Co-authored-by: lijianan <574980606@qq.com>
Co-authored-by: afc163 <afc163@gmail.com>
* fix: fix control value not show in dom

* chore: update title

* add test case

* change test title

* fix: cleared color should change after controlled value changed

* chore: code clean

* test: change test

* comment

* fix: should respect empty string

* test: add test case

* chore: update demo

---------

Co-authored-by: tanghui <yoyo837@hotmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Co-authored-by: lijianan <574980606@qq.com>
…t-design#48078)

Updates the requirements on [sharp](https://github.com/lovell/sharp) to permit the latest version.
- [Release notes](https://github.com/lovell/sharp/releases)
- [Changelog](https://github.com/lovell/sharp/blob/main/docs/changelog.md)
- [Commits](lovell/sharp@v0.33.2...v0.33.3)

---
updated-dependencies:
- dependency-name: sharp
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…design#48077)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: antd-style
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: react-countup
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: stylelint
  dependency-type: direct:development
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: yoshinyan <hai_hai_hai_1229@yahoo.co.jp>
* feat: deprecated-codesandbox

* feat: debug show csb
…t-design#48082)

* fix(site): fix the aside nav may cover the version dropdown box in some screen resolutions

* fix(review): fix code  review
* fix: fix the Wave not disappear when motion === false

* docs: update docs

* type: update type

* type: update type

* docs: revert
…design#48096)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: "@codesandbox/sandpack-react"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: "@types/react"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: puppeteer
  dependency-type: direct:development
  dependency-group: dev-dependencies
- dependency-name: stylelint
  dependency-type: direct:development
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: 社长长 <ischenkan@outlook.com>
li-jia-nan and others added 18 commits April 10, 2024 17:23
* docs(radio): comsummate radio group options type

* docs: optimize
Signed-off-by: Hao Dong <1476807+h-dong@users.noreply.github.com>
* refactor: use css token

* style: update
* feat: button support iconPosition

* fix: iconPosition compatible LoadingIcon

* docs(Button): update Button with iconPosition demo

* fix: delete debug type

* fix: iconPosition for InnerLoadingIcon with not existIcon

* chore: update button snapshots

* fix: fixed loading-icon-end style

* chore: refactor buttonContent with genButtonContent

* fix: iconPosition compatible with rtl

* docs(Button): update button with iconPosition demo

* chore: update test

* fix: iconPosition compatible with rtl

* docs(Buttob): add icon-position demo

* restore icon demo

* update snapshots

* docs: update icon button demo

* docs: update iconPosition button demo

* Update components/button/index.zh-CN.md

Co-authored-by: kiner-tang <1127031143@qq.com>
Signed-off-by: George H <default_hyn@163.com>

* Update components/button/index.zh-CN.md

Co-authored-by: kiner-tang <1127031143@qq.com>
Signed-off-by: George H <default_hyn@163.com>

* Update components/button/demo/icon-position.md

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: George H <default_hyn@163.com>

* Update components/button/index.en-US.md

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: George H <default_hyn@163.com>

* Update components/button/index.en-US.md

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: George H <default_hyn@163.com>

---------

Signed-off-by: George H <default_hyn@163.com>
Co-authored-by: kiner-tang <1127031143@qq.com>
Co-authored-by: afc163 <afc163@gmail.com>
* chore: improve publish process by skipping test command (ant-design#48230)

* chore: speed up publishing

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: check runs

* chore: skip test

* fix: types

* revert demo change

* fix: script

* chore: fix duplicate parts

* chore: fix duplicate parts

* chore: fix duplicate parts

* improve code

* use latest.hash

chore: download build artifacts from remote

chore: skip build when publish

chore: improve cli log

chore: fix something

chore: fix something

chore: fix something

chore: fix something

chore: fix something

chore: fix upload-build-artifacts

chore: fix needs

chore: fix needs

* chore: check map files

* chore: check package diff before publish

* chore Please use `npm publish` instead

* chore: sort-package-json

* chore: fix needs

* chore: import download process

* fix types

* fix types

* chore: update scripts

* chore: codesandbox ci

* fix token:statistic

* fix token:statistic

* fix ci

* fix ci

* chore: codesandbox ci

* fix ci

* chore: only upload when push to master
…gn#48320)

* demo: fix linear gradient button demo and remove debug flag

* fix active colors
…#48323)

* chore: add notice before publish to npm

* chore: remove progress
* docs: fix code

* feat: lint

* feat: prettier

* feat: test

* feat: review

* feat: format html

* feat: format html
* feat: Alert support id and ref

* test: add test case

* chore: adjust ts def

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
* feat: Input.OTP support mask prop

* fix: fix

* fix: fix

* test: add test case

* test: add test case

* chore: fix

* chore: update

* chore: remove

* chore: rename useOTPSingleValue

* fix: fix

* fix: fix

* chore: rm 3 lib

* chore: add 3 lib

* fix: fix

* fix: fix

* test: fix test case

* test: fix test case

* fix: fix

* fix: fix

---------

Signed-off-by: lijianan <574980606@qq.com>
Copy link
Contributor

Hi @CooperHash. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 10, 2024

-f 推送

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 10, 2024

先推送,我再reopen

@CooperHash
Copy link
Contributor Author

-f推送后,没有给这个pr新增commit,而是这样...
image

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 10, 2024

你checkout的是不是feature分支?

@CooperHash
Copy link
Contributor Author

g..记不太清了,好像是master

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 10, 2024

那rebase时就应该 rebase upstream/master;

但是作为新增功能,你应该检出feature来修改;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.mentions组件删除at的人可以整体删除而不是删除字