feat(swiper): support RTL mode #6450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1587315093
reviewed
Nov 23, 2023
src/components/swiper/index.en.md
Outdated
| @@ -36,6 +36,10 @@ When you use a vertical Swiper, be sure to set its height through the `--height` | |||
|
|
|||
| <code src="./demos/demo7.tsx" debug></code> | |||
|
|
|||
| ### rtl support | |||
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6450.surge.sh |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6450 +/- ##
==========================================
+ Coverage 92.10% 92.25% +0.15%
==========================================
Files 316 316
Lines 6861 6883 +22
Branches 1719 1743 +24
==========================================
+ Hits 6319 6350 +31
+ Misses 504 497 -7
+ Partials 38 36 -2 ☔ View full report in Codecov by Sentry. |
|
@1587315093 修改过了，麻烦再review一下哇 |
|
@zombieJ 麻烦看一下呢，这个提交已经pending一个月了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #6446
Swiper components support RTL