ColorPicker #3755
Open
ColorPicker #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ElderJames
reviewed
Mar 27, 2024
| </CascadingValue> | ||
|
|
||
| <style> | ||
| .mud-picker-color-picker { |
There was a problem hiding this comment.
please change the class prefix to ant- and move them to less files.
ElderJames
reviewed
Mar 27, 2024
| { | ||
| public static class KeepInRangeExtensions | ||
| { | ||
| public static double EnsureRange(this double input, double max) => EnsureRange(input, 0.0, max); |
There was a problem hiding this comment.
Please change the access modifier of extension methods to internel.
ElderJames
reviewed
Mar 27, 2024
| type: Data Display | ||
| title: Popover | ||
| cover: https://gw.alipayobjects.com/zos/alicdn/1PNL1p_cO/Popover.svg | ||
| --- |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3755 +/- ##
==========================================
- Coverage 43.54% 43.03% -0.52%
==========================================
Files 578 583 +5
Lines 28117 28443 +326
Branches 5694 5740 +46
==========================================
- Hits 12244 12240 -4
- Misses 14862 15193 +331
+ Partials 1011 1010 -1 ☔ View full report in Codecov by Sentry. |
|
style file modifed and class of extensions had modified, also the index.en-us.md had been changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
📝 Changelog
ColorPicker 颜色选择器
☑️ Self Check before Merge