Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter "HtmlTitle" added to components derived from AntComponentBase #3540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abin-Liu
Copy link
Contributor

@Abin-Liu Abin-Liu commented Dec 1, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Parameter "HtmlTitle" added to components derived from AntComponentBase

📝 Changelog

Most ant components now support the primitive html tooltip using property "HtmlTitle ", for example:

<Button HtmlTitle="Click for details ...">Click Me</Button>

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 1, 2023

@Abin-Liu
Copy link
Contributor Author

Abin-Liu commented Dec 1, 2023

Donno why the issue link could not be inserted, here it is:
#3537

@Abin-Liu
Copy link
Contributor Author

Abin-Liu commented Dec 1, 2023

@Abin-Liu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@ElderJames
Copy link
Member

Thank you for contribution @Abin-Liu , please fix the tests as well.

@Abin-Liu
Copy link
Contributor Author

Abin-Liu commented Dec 1, 2023

Thank you for contribution @Abin-Liu , please fix the tests as well.

I tried to build the tests right after cloning the project (before any change made to the code), it just wouldn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants