DatePicker - Input Masking bugs #3470 resolved

[agolub-s]

🤔 This is a ...

• New feature
• Bug fix
• Site / documentation update
• Demo update
• Component style update
• Bundle size optimization
• Performance optimization
• Refactoring
• Code style optimization
• Test Case
• Branch merge
• Other (about what?)

🔗 Related issue link

#3470

💡 Background and solution

📝 Changelog

Refactoring, fix bugs

Language	Changelog
🇺🇸 English	-
🇨🇳 Chinese	-

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Changelog is provided or not needed

[github-actions]

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6be83e4) 44.47% compared to head (0e7c711) 44.73%.
Report is 2 commits behind head on master.

❗ Current head 0e7c711 differs from pull request most recent head 4f63566. Consider uploading reports for the commit 4f63566 to get more accurate results

Files	Patch %	Lines
components/date-picker/internal/DatePickerBase.cs	63.33%	7 Missing and 4 partials ⚠️
...date-picker/internal/DateTimeInputMaskConverter.cs	70.58%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3481      +/-   ##
==========================================
+ Coverage   44.47%   44.73%   +0.25%     
==========================================
  Files         566      566              
  Lines       27182    26896     -286     
  Branches     5577     5573       -4     
==========================================
- Hits        12090    12031      -59     
+ Misses      14101    13892     -209     
+ Partials      991      973      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ElderJames]

Thank you for your contribution @agolub-s . I will reviee this ASAP. BTW, do you have any idea for the more generic input masking？Here is the issue #3217

[agolub-s]

Thank you for your contribution @agolub-s . I will reviee this ASAP. BTW, do you have any idea for the more generic input masking？Here is the issue #3217

DatePicker has own input controls. But we can use same logic, like copy-paste or create a generic input control for all inputs (more complex). I think easiest way to create Mask Input control for text, with properties: Converter, Allowed Symbols, Replace Symbols like in DateTimeInputMaskConverter

[ElderJames]

Hello @agolub-s , I found that the Tab key can't work correctly, the input box can't navigate by Tab key.

[agolub-s]

Hello @agolub-s , I found that the Tab key can't work correctly, the input box can't navigate by Tab key.

Fixed, but the last input not working in the form, I dont know why, do you have ideas?

[ElderJames]

Hello @agolub-s , what did you mean "the last input not working in the form"?

[agolub-s]

@ElderJames try to press tab on this input, can't go to next element

[ElderJames]

@agolub-s This is beacue you set the PreventDefault. I think it needs to exclude tab and arrow keys.

[ElderJames]

Hello @agolub-s , do you have any idea?

[agolub-s]

Hello @agolub-s , do you have any idea?

No, I found other bugs, I tried to fix it, but does not have time (need more), I'm busy with my work, I think I will try later. Sorry

[ElderJames]

Hey @agolub-s , may I ask if you have time to continue to push forward this PR?

[ElderJames]

Hello @agolub-s , is there any progress on this PR?