fix(module:descriptions) #3330
Open
fix(module:descriptions) #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@microsoft-github-policy-service agree |
ElderJames
reviewed
Jul 1, 2023
| @@ -34,12 +34,14 @@ protected override void Dispose(bool disposing) | |||
| { | |||
| this.Descriptions?.Items.Remove(this); | |||
| base.Dispose(disposing); | |||
| this.Descriptions?.ReRender(); | |||
| } | |||
There was a problem hiding this comment.
It鈥榮 better to add a pair of method for Descriptions naming 'AddItem' and RemoveItem, then call them in DescriptionItems.
trigger prepare data and rerender after child content changed
|
@dotnet-policy-service agree |
|
@ElderJames please check again:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trigger prepare data and rerender after child content changed
this fix #3326
馃 This is a ...