Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module: table): reduced rendered cell instances #3321

Open
wants to merge 29 commits into
base: feature
Choose a base branch
from

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor Table reduced rendered cell instances
🇨🇳 Chinese 重构 Table 减少渲染单元格实例

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 25, 2023

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.94% ⚠️

Comparison is base (d05f24d) 46.71% compared to head (400afb6) 43.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3321      +/-   ##
===========================================
- Coverage    46.71%   43.78%   -2.94%     
===========================================
  Files          558      559       +1     
  Lines        27013    27932     +919     
  Branches       267      267              
===========================================
- Hits         12620    12230     -390     
- Misses       14353    15662    +1309     
  Partials        40       40              
Files Changed Coverage Δ
components/table/ActionColumn.razor 0.00% <0.00%> (ø)
components/table/ActionColumn.razor.cs 0.00% <ø> (ø)
components/table/Column.razor 0.00% <0.00%> (ø)
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/table/ColumnBase.cs 0.00% <0.00%> (ø)
components/table/ColumnContext.cs 0.00% <0.00%> (ø)
components/table/GenerateColumns.razor.cs 0.00% <0.00%> (ø)
components/table/Internal/ColumnDataIndexHelper.cs 0.00% <0.00%> (ø)
components/table/Internal/Defer.cs 0.00% <0.00%> (ø)
components/table/PropertyColumn.cs 0.00% <0.00%> (ø)
... and 10 more

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames mentioned this pull request Jul 2, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant