Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .venv and .tox dirs to .gitignore and .ansible-lint config files #4176

Merged
merged 1 commit into from May 21, 2024

Conversation

trfore
Copy link
Contributor

@trfore trfore commented Apr 30, 2024

I don't have an intricate knowledge all the CI workflows in this repo or the parent team-devtools, so if there is rational for including .venv then please ignore or cherry-pick this PR. But it would be helpful for local dev given:

  • building and installing molecule-*.whl can introduce 3rd party packages into local .venv that ansible-lint (via tox -e lint or ansible-lint) will throw errors on and prevent pushing commits.
  • creating .venv will trigger git to check for changes, while this can be blocked using a global ignore file, not everyone uses or can use it.

I did not edit .yamllint, but running it via CLI yamllint . will throw similar errors. However, the pre-commit configuration skips these directories. A quick fix to .yamllint would be:

extends: default
ignore:
  - .tox/
  - .venv/
rules:
...

- building and installing molecule-*.whl can introduce 3rd party
  packages that ansible-lint will throw errors on
@ssbarnea ssbarnea merged commit a3fcd26 into ansible:main May 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants