Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not invoke not existing methods #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madox2
Copy link

@madox2 madox2 commented Nov 17, 2016

As the addListener and removeListener methods are not part of Animated interface it should be called defensively.

Specifically, I faced problem when _parent property of AnimatedInterpolation was instance of AnimatedModulo (which does not implement removeListener method). On component unmount it called __detach method which afterwards throwed an uncaught error.

@lelandrichardson
Copy link
Contributor

I believe #49 should fix this, though it may not be a bad idea to add this and be defensive anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants