New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(google-maps): switch to non-deprecated API for clustering and su… #28869
base: main
Are you sure you want to change the base?
Conversation
…pport for advanced markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crisbeto Based on your code i have created a PR to support clusters for both markers and advanced markers. I know that the API between old and new clusters are different but in my opinion it's good idea to update library especially that many people waiting for it. And my code support old markers and new markers. Let me know what do you think about it |
I don't think that we would want to support both clustering APIs in a single component since it's too much responsibility for one component and it'll make it harder to delete later. I'll see if I can get #24853 moving again. |
@crisbeto I mean I have implemented only one clusterer (the new one) but with support for marker and advanced marker. |
@crisbeto support for the "new" markerclusterer is highly appreciated. The new one supports handling for both new and old markers, so I think this PR makes total sense. I stopped using the angular components years ago, because they didn't support the newest changes with the algorithms and the render function. Thought after upgrading to 17 I can finally use them. But doesn't seem so... |
Any chance this arrives in v18? I recently started using Angular Google Maps and started with the advanced markers due to the deprecation warning. I would like to use the marker clusters. |
This commit update map marker cluster and support map marker and map advanced marker.
It's related to:
#23695
#24853