SntpClient periodically re-syncs the offset to NTP server #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the Android TV platforms do not report accurate `SystemClock.elapsedRealtime()` In addition this drift is not consistant accross multiple boxes, so the time offset between any pair of boxes will vary over time. This variance will lead to a drift in the Live Offset calculation. Fix is simple, inValidate the NTP server query after a period of time (10 minutes) and re-issue the call
|
See bug #696 |
|
@marcbaechinger as you can see, with Google TV time is off by 2 seconds from my workstation (which is a Ventura Mac synchronized to NTP): With this pull request and the one that fixes #702 we can play video on two devices synchronized. We are shipping this feature on our 1.15 based ExoPlayer product, my company is graciously allowing me to share the required changes. Let me know if you want a live HLS URL to play with I can sent it to a private email only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the Android TV platforms do not report accurate
SystemClock.elapsedRealtime()In addition this drift is not consistant accross multiple boxes, so the time offset between any pair of boxes will vary over time.This variance will lead to a drift in the Live Offset calculation.
Fix is simple, inValidate the NTP server query after a period of time (10 minutes) and re-issue the call