Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up conditionals in PiP logic #69

Merged
merged 2 commits into from May 8, 2024
Merged

Clean up conditionals in PiP logic #69

merged 2 commits into from May 8, 2024

Conversation

MagicalMeghan
Copy link
Contributor

Clean up nested if statements in updated PiP aspect ratio code

wu-perry
wu-perry approved these changes Apr 30, 2024
View reviewed changes
Copy link

@wu-perry wu-perry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up.

@MagicalMeghan
Update VideoPlayerScreen.kt
03f195d 
Checking if video size is not unknown checks that the height and width are not 0
@calren calren self-requested a review May 8, 2024 23:32
calren
calren approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@calren calren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MagicalMeghan !!

@MagicalMeghan MagicalMeghan merged commit 042bb37 into main May 8, 2024
2 checks passed
@MagicalMeghan MagicalMeghan deleted the pip-add-extension branch May 8, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calren calren calren approved these changes

@wu-perry wu-perry wu-perry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MagicalMeghan @calren @wu-perry