Update SyncWorker to show notifications for foreground service
#1403
Conversation
| @@ -67,6 +67,7 @@ internal class SyncWorker @AssistedInject constructor( | |||
| traceAsync("Sync", 0) { | |||
| analyticsHelper.logSyncStarted() | |||
|
|
|||
| setForeground(getForegroundInfo()) | |||
There was a problem hiding this comment.
CoroutineWorker#setForeground(ForegroundInfo)
Makes the
CoroutineWorkerrun in the context of a foregroundandroid.app.Service. This is a suspending function unlike thesetForegroundAsyncAPI which returns aListenableFuture.
CallingsetForegroundwill throw anIllegalStateExceptionif the process is subject to foreground service restrictions. Consider usingWorkRequest.Builder.setExpeditedandgetForegroundInfoinstead.
Are we sure we want this since we are already using setExpedited?
There was a problem hiding this comment.
In versions of Android prior to Android 12, overrid the getForegroundInfo() method would automatically display a notification when a CoroutineWorker was running in the foreground. However, from Android 12 onwards, this notification is no longer shown. This change could make it difficult for users to be aware that a foreground work is actively running. - link
Therefore, setForeground() was add to explicitly notify users of ongoing foreground works.
There was a problem hiding this comment.
I feel like this becomes redundant with the main loading indicator on the home page. Let's see what the maintainers expect 👍
What I have done and why
Fix to ensure notifications are visible for foreground synchronization of Topic and News Data.