Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add internal keyword to SettingsDialog #1389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyh990517
Copy link

@lyh990517 lyh990517 commented Apr 21, 2024

Thanks for submitting a pull request. Please include the following information.

What I have done and why

The Internal keyword was added to settingDialog, which is only referenced inside the module.
It seems there is no need to use it externally.

How I'm testing it

I simply built and ran it.

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

Change-Id: Ib8f62784ff5a2171e5d0e77f8753d4f3f94d4a4f
Copy link

google-cla bot commented Apr 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant