Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for AnimatedPane by delaying navigation #1387

Closed
wants to merge 1 commit into from

Conversation

alexvanyo
Copy link
Contributor

An alternative workaround to #1380 by delaying navigation until the nested NavHost has been composed at least once.

@alexvanyo alexvanyo requested a review from jdkoren April 17, 2024 18:47
Copy link

Combined test coverage report

Overall Project 40.37% -0.06% 🍏
Files changed 90.5% 🍏

Module Coverage
topic 46.54% -0.51%
app 30.73% -0.19% 🍏
Files
Module File Coverage
topic TopicNavigation.kt 20.37% -9.88%
app Interests2PaneViewModel.kt 100% 🍏
InterestsListDetailScreen.kt 90.61% -3.01% 🍏

Change-Id: I1b8710ec938048e210edca3bd7323c3fe5ab00c2
@alexvanyo alexvanyo force-pushed the av/nested-nav-with-animated-pane-2 branch from 93c1852 to b7effaf Compare April 25, 2024 19:37
Copy link

Combined test coverage report

Overall Project 40.58% -0.06% 🍏
Files changed 92.58% 🍏

Module Coverage
topic 47.09% -0.46%
app 33.1% -0.18% 🍏
Files
Module File Coverage
topic TopicNavigation.kt 20.37% -9.88%
app Interests2PaneViewModel.kt 100% 🍏
InterestsListDetailScreen.kt 91.68% -2.51% 🍏

@alexvanyo
Copy link
Contributor Author

Closed in favor of #1380

@alexvanyo alexvanyo closed this May 6, 2024
@alexvanyo alexvanyo deleted the av/nested-nav-with-animated-pane-2 branch May 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant