Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to navigation 2.7.7 #1383

Merged
merged 2 commits into from May 3, 2024
Merged

Update to navigation 2.7.7 #1383

merged 2 commits into from May 3, 2024

Conversation

alexvanyo
Copy link
Contributor

@alexvanyo alexvanyo commented Apr 17, 2024

Updates navigation to 2.7.7.

This required a strange workaround to how we applied a Modifier to NiaNavHost. Without this workaround, we would loose saved instance state in all of the screens.

I'm not sure why the workaround works, but reported https://issuetracker.google.com/338478720

Copy link

Combined test coverage report

Overall Project 40.19% 🍏

There is no coverage information present for the Files changed

Change-Id: Iaceea1fc216c899f7fac58e7f5eeaea4e1c10dbb
Copy link

Combined test coverage report

Overall Project 40.19% 🍏

There is no coverage information present for the Files changed

Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e
@alexvanyo alexvanyo changed the title [Do not merge] Update to navigation 2.7.7 Update to navigation 2.7.7 May 3, 2024
@alexvanyo alexvanyo requested review from dturner and jdkoren May 3, 2024 00:30
Copy link

github-actions bot commented May 3, 2024

Combined test coverage report

Overall Project 40.41% -0.04% 🍏
Files changed 60% 🍏

Module Coverage
app 31.93% -0.23% 🍏
Files
Module File Coverage
app NiaApp.kt 83.56% -1.33% 🍏

@dturner dturner merged commit afad1b9 into main May 3, 2024
4 checks passed
@dturner dturner deleted the av/navigation-2.7.7 branch May 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants