Add NavigationSuiteScaffold

[alexvanyo]

Adds NavigationSuiteScaffold to replace the current manual logic to switch between a navigation rail and navigation bar.

[github-actions]

Combined test coverage report

Overall Project	39.65% -1.03%	❌
Files changed	39.34%	❌

Module	Coverage
designsystem	30.38% -3.24%	❌
app	29.38% -0.87%	🍏

Files

Module	File	Coverage
designsystem	Navigation.kt	14.7% -24.13%	❌
app	NiaAppState.kt	90.27%	🍏
	NiaApp.kt	86.4% -6.22%	🍏
	MainActivity.kt	77.6% -1.08%	❌

[github-actions]

Combined test coverage report

Overall Project	39.65% -1.03%	❌
Files changed	39.34%	❌

Module	Coverage
designsystem	30.38% -3.24%	❌
app	29.38% -0.87%	🍏

Files

Module	File	Coverage
designsystem	Navigation.kt	14.7% -24.13%	❌
app	NiaAppState.kt	90.27%	🍏
	NiaApp.kt	86.4% -6.22%	🍏
	MainActivity.kt	77.6% -1.08%	❌

[alexvanyo]

This is changing the tonal elevation we are using for the navigation bar, as the NavigationSuiteScaffold doesn't allow that much customization.

If we strongly feel like we want to keep the current look of the navigation bar (which is overriding the tonal elevation to 0dp), then the intended usage would be to just set up the navigation UI manually, like we are doing right now, but then we wouldn't be using NavigationSuiteScaffold.

[IanGClifton]

Another option would be overriding the navigation bar colors specifically to what it would be with that elevation, but that seems a bit like fighting the APIs. I think the new colors look fine, but I don't know who should approve them.

[alexvanyo]

That could work, but eww... especially since we have to handle dynamic colors and the Android colors.

@dturner do you think the visual update here is fine to merge with?

[IanGClifton]

LGTM but I think someone else needs to approve for the color changes. It seems more inline with what M3 generally looks like, but I don't know if there was any history in the decision.

[IanGClifton]

Another option would be overriding the navigation bar colors specifically to what it would be with that elevation, but that seems a bit like fighting the APIs. I think the new colors look fine, but I don't know who should approve them.

[github-actions]

Combined test coverage report

Overall Project	39.74% -0.92%	❌
Files changed	42.19%	❌

Module	Coverage
designsystem	30.53% -2.83%	❌
app	30.42% -0.85%	🍏

Files

Module	File	Coverage
designsystem	Navigation.kt	15.12% -21.55%	❌
app	NiaAppState.kt	90.27%	🍏
	NiaApp.kt	86.52% -6.16%	🍏
	MainActivity.kt	77.72% -1.07%	❌

[github-actions]

Combined test coverage report

Overall Project	39.74% -0.92%	❌
Files changed	42.19%	❌

Module	Coverage
designsystem	30.53% -2.83%	❌
app	30.42% -0.85%	🍏

Files

Module	File	Coverage
designsystem	Navigation.kt	15.12% -21.55%	❌
app	NiaAppState.kt	90.27%	🍏
	NiaApp.kt	86.52% -6.16%	🍏
	MainActivity.kt	77.72% -1.07%	❌