Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload connectivity monitor to a background thread #1368

Merged
merged 2 commits into from May 7, 2024

Conversation

mlykotom
Copy link
Contributor

What I have done and why

Moved the ConnectivityManagerNetworkMonitor to a background thread to prevent blocking main thread by ~5ms during startup.

image

How I'm testing it

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Change-Id: I9a2ef7766ae6abc6d8a7c86a4b49ef3c795e446c
Copy link

Combined test coverage report

Overall Project 39.97% -0.2%
Files changed 0%

Module Coverage
data 59.65% -5.52%
Files
Module File Coverage
data ConnectivityManagerNetworkMonitor.kt 0% -60.65%

Change-Id: Ib6f7678f5f1c4b0f93f1736b6453c649d6f7dc97
Copy link

Combined test coverage report

Overall Project 39.95% -0.2%
Files changed 0%

Module Coverage
data 59.67% -5.56%
Files
Module File Coverage
data ConnectivityManagerNetworkMonitor.kt 0% -61.4%

@mlykotom mlykotom merged commit 7f2ce57 into main May 7, 2024
4 checks passed
@mlykotom mlykotom deleted the mlykotom/offload-connectivity-monitor branch May 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants