Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #27

Open
wants to merge 4 commits into
base: update-yaml-files
Choose a base branch
from
Open

Fix build #27

wants to merge 4 commits into from

Conversation

Lamkhang21
Copy link

samtstern and others added 4 commits September 20, 2019 09:54
- Include a fake google-services.json
- Include the placeholder strings for URLs in the strings.xml
- Remove app/google-services.json from the gitignore so that a fake file
  can be in the repository
- Use google() for adding the google maven repository
- Replace compile as implementation in the build.gradle
@google-cla
Copy link

google-cla bot commented Oct 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Lamkhang21
Copy link
Author

totien19955@gmail.com

@Lamkhang21 Lamkhang21 closed this Oct 14, 2020
@Lamkhang21 Lamkhang21 reopened this Oct 14, 2020
@ggfan
Copy link
Contributor

ggfan commented Jun 28, 2021

may you please rebase from main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants