[Jetcaster]: Display latest episodes for all subscribed podcasts in library. #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arriolac
commented
Apr 25, 2024
•
arriolac
commented
arriolac
force-pushed
the
chris/jetcaster/library
branch
from
d602d59
to
dc4fcef
Compare
mlykotom
reviewed
Apr 26, 2024
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
arriolac
force-pushed
the
chris/jetcaster/library
branch
from
737e634
to
392bb7a
Compare
arriolac
force-pushed
the
chris/jetcaster/library
branch
from
bc80fd3
to
f1231a4
Compare
mlykotom
approved these changes
Apr 29, 2024
| @@ -70,6 +73,9 @@ class HomeViewModel @Inject constructor( | |||
| // Holds the view state if the UI is refreshing for new data | |||
| private val refreshing = MutableStateFlow(false) | |||
|
|
|||
| private val subscribedPodcasts = podcastStore.followedPodcastsSortedByLastEpisode(limit = 10) | |||
There was a problem hiding this comment.
NIT: I'd add a comment why this uses shareIn operator as when someone reads it in the future, they will think "this is unnecessary" and remove it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.