Adding shared elements to Jetsnack 🎉 #1314
Open
+1,102
−545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riggaroo
changed the title
…ntent as it transitions in size. Clip the background during transition.
Fix overlap of detail text.
…ared-element # Conflicts: # Jetsnack/gradle/libs.versions.toml
jdkoren
reviewed
May 6, 2024
| @@ -41,183 +42,183 @@ val snacks = listOf( | |||
| price = 299 | |||
| ), | |||
| Snack( | |||
| id = 2L, | |||
| id = Random.nextLong(), | |||
There was a problem hiding this comment.
Cupcake above still has a fixed ID. Do these IDs need to be random? Also, isn't it now possible (albeit very improbable) that two snacks end up with the same ID?
There was a problem hiding this comment.
Its for preview purposes to be able to query for a certain snack. yes it is somewhat possible, but this is fake mock data so I dont think its worth the hassle of making it more robust.
…compose-samples into jetsnack/shared-element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding shared elements between Home feed and SnackDetail.
Introduced
SnackSharedElementKeyto create a unique key for the shared element to match.Using
Modifier.sharedBounds()on the Card container, andModifier.sharedElement()on the Image.Using
Modifier.sharedBounds()withModifier.animateEnterExit()on Text.The above modifiers require being in an
AnimatedVisibilityScopeandSharedTransitionScope, in order to use the correct scope at the correct point, we save the scopes in a CompositionLocal and retrieve it when required.jetsnack.mp4