Fix use of IMAGE:TAG syntax #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help text showed (and still shows) the option to use IMAGE:TAG for image, but in practice was trying to use this as the image name itself. Update to explicitly handle this - if used then, other ways of setting tags (e.g. --tags-like) are ignored. Still need to use -n 0 for consistency.
|
did you run tests against these changes? |
|
@andrey-pohilko I didn't run formal tests, just used the change in practice. I was hoping they might run automatically somewhere:) Can you point me as to how to run them? |
@john-forrest You can run existing tests via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help text showed (and still shows) the option to use IMAGE:TAG
for image, but in practice was trying to use this as the image name
itself. Update to explicitly handle this - if used then, other ways
of setting tags (e.g. --tags-like) are ignored. Still need to use
-n 0 for consistency.
This partly relates to #50.