Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for explicit cacert and client cert #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glance-
Copy link

@glance- glance- commented Jan 24, 2020

This adds flags to registry-cli to be able to specify ca certificate and client certificates to use when validating and talking to a registry service.

@ipavlushin
Copy link
Collaborator

@glance- thanks for your contribution. Could you add tests?

@glance-
Copy link
Author

glance- commented Sep 23, 2020

I'm not working with the project, and at the company this code was written for, so I don't have any work-time to spend on this.

Either just merge as is, classify it as abandoned or maybe in another year or two I might find this useful again and pick it up.

@glance-
Copy link
Author

glance- commented Sep 23, 2020

Also, its impossible to write any meaningful unit-tests for a feature like this. It would require one to set up quite extensive integration tests with tls proxies, CA's and such.

So, no, I won't be writing any tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants