fix function get_ordered_tags, add to get_datetime_tags args.plain param #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run:
/usr/bin/docker run --rm Image_from_commit_85bdf89027bdd22ed162d40117d8f5f28fea23f5 -l user:pass -r https://registry.domain --delete --num 8 --dry-run --order-by-date --debug
Got error:
[debug][funcname]: get_auth_schemes()
Traceback (most recent call last):
File "/registry.py", line 864, in
main_loop(args)
File "/registry.py", line 804, in main_loop
tags_list = get_ordered_tags(registry, image_name, all_tags_list, args.order_by_date)
File "/registry.py", line 729, in get_ordered_tags
tags_date = get_datetime_tags(registry, image_name, tags_list)
TypeError: get_datetime_tags() takes exactly 4 arguments (3 given)
[debug][docker] Auth schemes found:['basic']
Will delete all but 8 last tags
This PR resolve error.