Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compact code for reading password #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jylitalo
Copy link
Contributor

  • Even if the user has entered -w -l foo:bar, python will ignore bar as a password and either read it with getpass() or read from stdin.
  • "foo".split(':')[0] is no different from "foo:bar".split(':')[0]
  • regardless how a user gives password, python should check that the user has given password
  • python can use strip() to eliminate possible end-of-line character

The only slightly open topic that I can figure out is whether python should strip() password before python validates that the user has given a password or give him the option to use some whitespace to give an empty password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant